Value keeps overriding my old value in a session array

I have a very simple random number generator. This number generator has a few options: you input a minimum and maximum number, form this number a random number will be generated. I store the maximum-minimum and generated number inside of a session to be used later while playing the game.

When we get redirected to the main page (the guess game) you have the option to guess the random number that is stored in the session from their one forth the game will give you feedback on how close you are etc.

My question boils down to this, an option of the game is to display all your previous guesses I had a basic idea of how I wanted to do this: I will store the current guess I did inside of an array this array will be linked to a session from which I can loop through all of the old guesses.

I have written a couple of functions to achieve this and it only stores the current guess overriding any number already stored in the array e.g. if my current guess is 6 this number will be stored inside the array, if I proceed to guess again for example 4 this number will be stored inside of the array but will override 6.

I hope my code examples will be more clear.

this function stores the old guesses inside of said array

public function Store_Old_Guesses_In_Session()
{
    if (!isset($_SESSION["show_previous_guesses"])) {
        return false;
    }
    if (isset($_POST["Guess_Button"])) {
        return $_SESSION["old_guesses"] = $this->old_guesses = array(
            "Old_guesses" => $this->getCurrentGuess(),
        );
    }
    return false;
}

this function gets the current guess

public function getCurrentGuess()
{
    if (isset($this->current_guess)) {
        return $this->current_guess;
    }
    return false;
}

–


namespace Store;


use Get_NumberGet_Numbers;

require_once "Current_Guesses.php";

class Store_Numbers extends Get_Numbers
{
    public array $old_guesses;

    public function __construct()
    {
        parent::__construct();
        if (isset($_SESSION["old_guesses"])) {
            $this->old_guesses = $_SESSION["old_guesses"];
        }
    }

    public function Store_Current_Number_In_Session()
    {
        if (empty($this->getCurrentNumber())) {
            return false;
        }
        return $_SESSION["current_number"] = $this->getCurrentNumber();
    }

    public function Store_Minimum_Number_In_Session()
    {
        if (empty($this->getMinimumNumber())) {
            return false;
        }
        return $_SESSION["minimum_number"] = $this->getMinimumNumber();
    }

    public function Store_Maximum_Number_In_Session()
    {
        if (empty($this->getMaximumNumber())) {
            return false;
        }
        return $_SESSION["maximum_number"] = $this->getMaximumNumber();
    }

    public function Store_Checkbox_Value_In_Session()
    {
        if (empty($_POST["debug_options"])) {
            return false;
        }
        return $_SESSION["debug_options"] = $_POST["debug_options"];
    }

    public function Store_show_previous_guesses_Checkbox_In_Session()
    {
        if (empty($_POST["show_previous_guesses"])) {
            return false;
        }
        return $_SESSION["show_previous_guesses"] = $_POST["show_previous_guesses"];
    }

    public function Store_Current_Number_Checkbox_Value_In_Session()
    {
        if (empty($_POST["current_number_checkbox"])) {
            return false;
        }
        return $_SESSION["current_number_checkbox"] = $_POST["current_number_checkbox"];
    }

    public function Store_Old_Guesses_In_Session()
    {
        if (!isset($_SESSION["show_previous_guesses"])) {
            return false;
        }
        if (isset($_POST["Guess_Button"])) {
            $this->old_guesses[] = $this->getCurrentGuess();
            $_SESSION['old_guesses'] = array_push($this->old_guesses, $this->getCurrentGuess());
            return $this->old_guesses;
        }
        return false;
    }
}

I have a bunch of code examples should you need more

A few things you might need to know:

PHP = 7.4.2
The property $old_guesses is declared as an array like this public array $old_guesses;

Answer

You need to push onto the array, not assign to it.

public function Store_Old_Guesses_In_Session()
{
    if (!isset($_SESSION["show_previous_guesses"])) {
        return false;
    }
    if (isset($_POST["Guess_Button"])) {
        $this->old_guesses[] = $this->getCurrentGuess();
        $_SESSION['old_guesses'] = $this->old_guesses;
        return $this->old_guesses;
    }
    return false;
}

The constructor should initialize the variable from the session variable to make it persist and grow.

if (!isset($_SESSION['old_guesses'])) {
    $_SESSION['old_guesses'] = array();
}

$this->old_guesses = $_SESSION['old_guesses'];

Advertisement

Answer